Skip to content

[New Rule] AWS ECR Repository or Registry Policy Granted Public Access#6342

Open
bryans3c wants to merge 3 commits into
mainfrom
rule/aws-ecr-repository-policy-public-access
Open

[New Rule] AWS ECR Repository or Registry Policy Granted Public Access#6342
bryans3c wants to merge 3 commits into
mainfrom
rule/aws-ecr-repository-policy-public-access

Conversation

@bryans3c

Copy link
Copy Markdown
Contributor

Pull Request

Issue link(s):

Summary - What I changed

Detects an ECR repository or registry policy that grants public access (an Allow statement with a wildcard "*" principal), exposing the registry's container images, and any secrets baked into their layers, to everyone.

How To Test

Query can be used in TRADE stack and other telemetry stacks.

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

@bryans3c bryans3c self-assigned this Jun 29, 2026
Copilot AI review requested due to automatic review settings June 29, 2026 15:03
@bryans3c bryans3c added Integration: AWS AWS related rules Rule: New Proposal for new rule Domain: Cloud labels Jun 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Rule: New - Guidelines

These guidelines serve as a reminder set of considerations when proposing a new rule.

Documentation and Context

  • Detailed description of the rule.
  • List any new fields required in ECS/data sources.
  • Link related issues or PRs.
  • Include references.

Rule Metadata Checks

  • creation_date matches the date of creation PR initially merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive, considering performance for diverse environments. Non ecs fields should be added to non-ecs-schema.json if not available in an integration.
  • min_stack_comments and min_stack_version should be included if the rule is only compatible starting from a specific stack version.
  • index pattern should be neither too specific nor too vague, ensuring it accurately matches the relevant data stream (e.g., use logs-endpoint.process-* for process data).
  • integration should align with the index. If the integration is newly introduced, ensure the manifest, schemas, and new_rule.yaml template are updated.
  • setup should include the necessary steps to configure the integration.
  • note should include any additional information (e.g. Triage and analysis investigation guides, timeline templates).
  • tags should be relevant to the threat and align/added to the EXPECTED_RULE_TAGS in the definitions.py file.
  • threat, techniques, and subtechniques should map to ATT&CK always if possible.

New BBR Rules

  • building_block_type should be included if the rule is a building block and the rule should be located in the rules_building_block folder.
  • bypass_bbr_timing should be included if adding custom lookback timing to the rule.

Testing and Validation

  • Provide evidence of testing and detecting the expected threat.
  • Check for existence of coverage to prevent duplication.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new AWS CloudTrail detection rule to identify Amazon ECR repository/registry policy changes that grant public access via a wildcard principal, helping surface unintended exposure of container images (and potential embedded secrets).

Changes:

  • Introduces a new ES|QL rule targeting SetRepositoryPolicy and PutRegistryPolicy CloudTrail events.
  • Adds triage/investigation guidance, references, and MITRE ATT&CK mapping for analyst workflow.
  • Defines investigation fields intended to support alert review.
bryans3c and others added 2 commits June 29, 2026 21:07
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants