Add pattern attribute to .mac fields - #1871
Merged
Merged
Conversation
kgeller
approved these changes
Apr 11, 2022
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Apr 11, 2022
* set pattern attr on mac addr fields * need to handle when examples are an array of values * artifacts * mention pattern check for --strict * commenting * changelog (cherry picked from commit cbca435)
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR sets the
patternattribute for the.macaddress fields. The regex value is based on the format suggested in IETF RFC 7042.Other changes
patternattribute #1834 didn't handle examples with array values. Ifarrayis set in thenormalizedattribute, theexamplevalue is now treated as an array.patternregex will cause an exception if using--strict.This is now documented inUSAGE.md.Resolves #1846