Increase url.query ignore_above value to 2083#2424
Merged
mjwolf merged 6 commits intoelastic:mainfrom Jan 20, 2025
Merged
Conversation
Increasing the url.query ignore_above value will allow indexing longer query values which have been observed. 2083 is used because it will cover the maximum url length for Chrome (2048) and Internet Explorer (2083). Other browsers and web servers support longer URLs, and there is no absolute URL limit defined in any RFC. So higher values could be possible, supporting Chrome's maximum length will allow compatibility with the most common browser, while not increasing the index size too much.
qcorporation
approved these changes
Jan 20, 2025
qcorporation
left a comment
There was a problem hiding this comment.
please add event.url to the change. otherwise looks great!
Contributor
Author
I've made that change |
mjwolf
added a commit
to mjwolf/ecs
that referenced
this pull request
Jan 20, 2025
Increasing the url.query ignore_above value will allow indexing longer query values which have been observed. 2083 is used because it will cover the maximum url length for Chrome (2048) and Internet Explorer (2083). Other browsers and web servers support longer URLs, and there is no absolute URL limit defined in any RFC. So higher values could be possible, supporting Chrome's maximum length will allow compatibility with the most common browser, while not increasing the index size too much.
mjwolf
added a commit
that referenced
this pull request
Jan 21, 2025
Increasing the url.query ignore_above value will allow indexing longer query values which have been observed. 2083 is used because it will cover the maximum url length for Chrome (2048) and Internet Explorer (2083). Other browsers and web servers support longer URLs, and there is no absolute URL limit defined in any RFC. So higher values could be possible, supporting Chrome's maximum length will allow compatibility with the most common browser, while not increasing the index size too much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increasing the url.query ignore_above value will allow indexing longer query values which have been observed.
2083 is used because it will cover the maximum url length for Chrome (2048) and Internet Explorer (2083).
Other browsers and web servers support longer URLs, and there is no absolute URL limit defined in any RFC. So higher values could be possible, supporting Chrome's maximum length will allow compatibility with the most common browser, while not increasing the index size too much.
make test? ymakeand committed those changes?closes #105