[Helm charts] Properly quote boolean values

[ycombinator]

What does this PR do?

This PR fixes the quoting of boolean values agent.fleet.insecure and agent.fleet.force.

Why is it important?

Prior to the fix, the rendered values for these fields would appear like so, with an extra pair of quotes, which was causing the rendered value to be ineffective:

- name: FLEET_INSECURE
   value: '"true"'
- name: FLEET_FORCE
   value: '"true"'

Checklist

• I have read and understood the pull request guidelines of this project.
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in ./changelog/fragments using the changelog tool
• I have added an integration test or an E2E test

Disruptive User Impact

None; fixes a bug.

How to test this PR locally

1. Add insecure: true here.
2. Run mage helm:renderExamples
3. Verify that the env var in the rendered manifest only has a single pair of double quotes around the value.

Thanks @pkoutsovasilis for suggesting the fix and testing steps.

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[ebeahan]

LGTM. Thanks @pkoutsovasilis for the pointer to a fix.

[pkoutsovasilis]

hey @ycombinator, thanks for addressing this one. One proposal; go ahead add the insecure: true and force: true in the example you mention in the local testing. Then run mage helm:renderExamples and push all affected files in this PR. This way this will be always checked in the CI and hopefully will prevent any future issues with that

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: fcb1c37

Failed CI Steps

• Unit tests - macOS 15 ARM
• x86_64:sudo: install-uninstall
• arm:sudo: default

cc @ycombinator

[ycombinator]

hey @ycombinator, thanks for addressing this one. One proposal; go ahead add the insecure: true and force: true in the example you mention in the local testing. Then run mage helm:renderExamples and push all affected files in this PR. This way this will be always checked in the CI and hopefully will prevent any future issues with that

With insecure: true, the rendered env var is FLEET_INSECURE: "true". Are we sure we want to encourage this, by making it part of our examples?

Similarly, with force: true, the rendered env var is FLEET_FORCE: "true". This would cause the Agent container to re-enroll any time the container is created, regardless of whether a fleet.enc (or previously fleet.yml) file is present or not. Are we sure we want to encourage this, by making it part of our examples?

[pkoutsovasilis]

@ycombinator look at the README.md of this example we don't actually propose the users to use these values, we just have the values there to validate what we propose in the README actually works. So with that said, it feels ok to introduce some slight deviation between the README.md proposal and the under-the-hood values to increase our testing footprint. Your call, the change LGTM

[swiatekm]

Can you set these in one of the example configs, so we can see that the values are now rendered correctly?

[github-actions]

@Mergifyio backport 8.19 9.0 9.1 9.2

[mergify]

backport 8.19 9.0 9.1 9.2

✅ Backports have been created

Details

• #10858 [8.19] (backport #10681) [Helm charts] Properly quote boolean values has been created for branch 8.19
• #10859 [9.0] (backport #10681) [Helm charts] Properly quote boolean values has been created for branch 9.0
• #10860 [9.1] (backport #10681) [Helm charts] Properly quote boolean values has been created for branch 9.1
• #10861 [9.2] (backport #10681) [Helm charts] Properly quote boolean values has been created for branch 9.2

[ycombinator]

Can you set these in one of the example configs, so we can see that the values are now rendered correctly?

Shoot, I missed this comment before hitting merge. Sorry about that!

FWIW, I did test this locally; the steps are mentioned in the PR's description under "How to test this PR locally".