[otel config translate] allow hosts to be string not just slice

[leehinman]

What does this PR do?

Allows the hosts part of the beat output to be a string instead of a slice.

This is to match the behavior of beats which allows this.

Why is it important?

This means that more hand written configuration will work "out of the box" with beat receivers.

Checklist

• I have read and understood the pull request guidelines of this project.
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in ./changelog/fragments using the changelog tool
• I have added an integration test or an E2E test

Disruptive User Impact

None.

How to test this PR locally

cd internal/pkg/otel/translate
go test -run TestToOtelConfig

Related issues

• Closes OTel manager failed: failed to generate otel config: error translating config for output: ... source data must be an array or slice, got string #11352

Questions to ask yourself

• How are we going to support this in production?
• How are we going to measure its adoption?
• How are we going to debug this?
• What are the metrics I should take care of?
• ...

[mergify]

This pull request does not have a backport label. Could you fix it @leehinman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
• backport-active-all is the label that automatically backports to all active branches.
• backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
• backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: df5d2ac

Failed CI Steps

• Win2022:sudo:fleet
• arm:sudo: upgrade
• x86_64:non-sudo: default - platform-ingest-elastic-agent-debian-13-1762801856

cc @leehinman

[ycombinator]

I didn't quite follow why the "before" implementation wouldn't allow hosts to be a string but that might be because I don't have enough context.

The "after" implementation makes a lot of sense, though, since it's using the hosts from the Beat config object and I know that supports either string or list of strings for hosts.

[leehinman]

I didn't quite follow why the "before" implementation wouldn't allow hosts to be a string but that might be because I don't have enough context.

Yeah, it isn't obvious. But in elastic-agent we had an embedded HostWorkerConfig, and that has Hosts as a slice of strings. So when you did the decode it would complain about the type mismatch.

The "fix" here treats the configuration more like beats does. Like beats we don't unpack with the HostWorkerConfig, we use the same function ReadHostList to handle the Hosts and Worker value.

The "after" implementation makes a lot of sense, though, since it's using the hosts from the Beat config object and I know that supports either string or list of strings for hosts.

I'm cheating. Since we want bug for bug compatibility I'm just using the same code ;-)