Skip to content

Add Azure Asset Inventory definition to cloudbeat #5323

Merged
kubasobon merged 9 commits intoelastic:mainfrom
kubasobon:azure-asset-inventory
Sep 3, 2024
Merged

Add Azure Asset Inventory definition to cloudbeat #5323
kubasobon merged 9 commits intoelastic:mainfrom
kubasobon:azure-asset-inventory

Conversation

@kubasobon
Copy link
Member

What does this PR do?

Add Azure Asset Inventory definition to Cloudbeat

Why is it important?

Asset Inventory integration defines separate inputs per upstream cloud provider type. Hence a separate definition for Azure.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

No disruptions expected, this is a new feature.

Related issues

Closes https://github.com/elastic/security-team/issues/10085

@kubasobon kubasobon requested a review from a team as a code owner August 20, 2024 12:27
@kubasobon kubasobon added the enhancement New feature or request label Aug 20, 2024
@kubasobon kubasobon self-assigned this Aug 20, 2024
@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2024

This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Aug 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@ycombinator ycombinator force-pushed the azure-asset-inventory branch from f76eeb0 to 5bdd332 Compare August 21, 2024 19:13
@kubasobon
Copy link
Member Author

@pchila I'd be happy to merge this, but can't due to failing buildikite runs (same issue on main). Would you be so kind as to merge this or instruct me how to fix the issue?

@pchila
Copy link
Member

pchila commented Sep 3, 2024

@pchila I'd be happy to merge this, but can't due to failing buildikite runs (same issue on main). Would you be so kind as to merge this or instruct me how to fix the issue?

@kubasobon
From what I can see on the last CI run there's a flaky test failing and some provisioning issues... I would update your branch with main once more as we merged some fixes for flaky tests and see if you get a clean run with up-to-date code

@kubasobon kubasobon enabled auto-merge (squash) September 3, 2024 19:23
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kubasobon kubasobon merged commit 764ae9f into elastic:main Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

4 participants