Skip to content

Add fips attribute to agent metadata sent to fleet#7112

Merged
michel-laterman merged 6 commits intoelastic:mainfrom
michel-laterman:agent-metadata-fips
Mar 5, 2025
Merged

Add fips attribute to agent metadata sent to fleet#7112
michel-laterman merged 6 commits intoelastic:mainfrom
michel-laterman:agent-metadata-fips

Conversation

@michel-laterman
Copy link
Contributor

What does this PR do?

Add elastic.agent.fips (bool) attribute to local_metadata sent with enroll and checkin requests.
The value of this attribute indicates if the agent is a FIPS compliant distribution.

Why is it important?

elastic-agent needs to be able to signal to fleet-server if it is running a FIPS distributable.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

N/A

@michel-laterman michel-laterman added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Feb 28, 2025
@michel-laterman michel-laterman requested a review from a team as a code owner February 28, 2025 20:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@jlind23
Copy link
Contributor

jlind23 commented Mar 3, 2025

@michel-laterman seems like unit tests need to be updated to add the fips field in the expected json.

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @michel-laterman

@michel-laterman michel-laterman merged commit baaeef5 into elastic:main Mar 5, 2025
14 checks passed
mergify bot pushed a commit that referenced this pull request Mar 5, 2025
Add elastic.agent.fips (bool) attribute to local_metadata sent with enroll and checkin requests.
The value of this attribute indicates if the agent is a FIPS compliant distribution.

(cherry picked from commit baaeef5)

# Conflicts:
#	internal/pkg/agent/application/coordinator/diagnostics_test.go
mergify bot pushed a commit that referenced this pull request Mar 5, 2025
Add elastic.agent.fips (bool) attribute to local_metadata sent with enroll and checkin requests.
The value of this attribute indicates if the agent is a FIPS compliant distribution.

(cherry picked from commit baaeef5)

# Conflicts:
#	internal/pkg/agent/application/coordinator/diagnostics_test.go
mergify bot pushed a commit that referenced this pull request Mar 5, 2025
Add elastic.agent.fips (bool) attribute to local_metadata sent with enroll and checkin requests.
The value of this attribute indicates if the agent is a FIPS compliant distribution.

(cherry picked from commit baaeef5)

# Conflicts:
#	internal/pkg/agent/application/coordinator/diagnostics_test.go
michel-laterman added a commit that referenced this pull request Mar 6, 2025
Add elastic.agent.fips (bool) attribute to local_metadata sent with enroll and checkin requests.
The value of this attribute indicates if the agent is a FIPS compliant distribution.

(cherry picked from commit baaeef5)
michel-laterman added a commit that referenced this pull request Mar 6, 2025
Add elastic.agent.fips (bool) attribute to local_metadata sent with enroll and checkin requests.
The value of this attribute indicates if the agent is a FIPS compliant distribution.

(cherry picked from commit baaeef5)
michel-laterman added a commit that referenced this pull request Mar 6, 2025
Add elastic.agent.fips (bool) attribute to local_metadata sent with enroll and checkin requests.
The value of this attribute indicates if the agent is a FIPS compliant distribution.

(cherry picked from commit baaeef5)
michel-laterman added a commit that referenced this pull request Mar 6, 2025
Add elastic.agent.fips (bool) attribute to local_metadata sent with enroll and checkin requests.
The value of this attribute indicates if the agent is a FIPS compliant distribution.

(cherry picked from commit baaeef5)

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
michel-laterman added a commit that referenced this pull request Mar 7, 2025
Add elastic.agent.fips (bool) attribute to local_metadata sent with enroll and checkin requests.
The value of this attribute indicates if the agent is a FIPS compliant distribution.

(cherry picked from commit baaeef5)

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
@michel-laterman michel-laterman deleted the agent-metadata-fips branch March 13, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

4 participants