feat(opentelemetry-node): central config support for 'logging_level' using OpAMP#834
Merged
feat(opentelemetry-node): central config support for 'logging_level' using OpAMP#834
Conversation
…using OpAMP This adds initial central config support for EDOT Node.js. Communication is over OpAMP, to an EDOT Collector using the apmconfig extension (https://github.com/elastic/opentelemetry-collector-components/tree/main/extension/apmconfigextension) Also: - Improve CLI option to mockopampserver to more easily play with remote config it offers. - Improve heartbeatIntervalSeconds normalization in opamp-client-node. Refs: #628
3 tasks
david-luna
reviewed
Jun 18, 2025
…point This endpoint can be use to update the live Agent Config offered by a running MockOpAMPServer. This can be useful for testing. This endpoint is not part of OpAMP, so it is only enabled when 'testMode: true'. Also add a '-T' option for starting the server in test mode.
Also add a feature to `runTestFixtures` that allows lazy eval of the "env" values for the test fixtures. This is being used to allow determining an envvar value *after* a test case has run (a setup case that starts a MockOpAMPServer for some of the fixtures).
… for EDOT Node.js tests
…l opamp-client-node as well
theletterf
approved these changes
Jun 23, 2025
david-luna
approved these changes
Jun 23, 2025
Member
david-luna
left a comment
david-luna
left a comment
There was a problem hiding this comment.
I see XXX comments in your files. If they are temporal changes for the sake of testing you may change them to TODO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds initial central config support for EDOT Node.js.
Communication is over OpAMP, to an EDOT Collector using the
apmconfig extension (https://github.com/elastic/opentelemetry-collector-components/tree/main/extension/apmconfigextension)
Also:
Refs: #628
status
The best way to play with this initially is the heavily-documented https://github.com/elastic/elastic-otel-node/blob/trentm-central-config3/examples/central-config.js