Skip to content

Add missing py.typed to sdk #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrmx merged 3 commits into from
Sep 25, 2024
Merged

Add missing py.typed to sdk #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b32917
sdk: add missing py.typed
xrmx Sep 24, 2024
9837531
sdk: add type annotations to resource detectors
xrmx Sep 24, 2024
d4d0d8a
Merge branch 'main' into add-missing-pytyped-to-sdk
xrmx Sep 25, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added src/elasticotel/sdk/py.typed
View file
Open in desktop
Empty file.
5 changes: 3 additions & 2 deletions src/elasticotel/sdk/resources/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

from opentelemetry.semconv._incubating.attributes import telemetry_attributes
from opentelemetry.sdk.resources import (
Attributes,
Resource,
ResourceDetector,
PROCESS_RUNTIME_DESCRIPTION,
Expand All @@ -42,7 +43,7 @@ def detect(self) -> "Resource":
),
)
)
resource_info = {
resource_info: Attributes = {
PROCESS_RUNTIME_DESCRIPTION: sys.version,
PROCESS_RUNTIME_NAME: sys.implementation.name,
PROCESS_RUNTIME_VERSION: runtime_version,
Expand All @@ -54,7 +55,7 @@ class TelemetryDistroResourceDetector(ResourceDetector):
"""Resource detector to fill telemetry.distro attributes"""

def detect(self) -> "Resource":
resource_info = {
resource_info: Attributes = {
telemetry_attributes.TELEMETRY_DISTRO_NAME: "elastic",
telemetry_attributes.TELEMETRY_DISTRO_VERSION: version.__version__,
}
Expand Down