Merged
Conversation
swallez
approved these changes
Aug 22, 2025
Contributor
swallez
left a comment
swallez
left a comment
There was a problem hiding this comment.
LGTM, once the explanation comment has been added.
|
|
||
| List<ByteBuffer> bodyBuffers = null; | ||
| HeaderMap headers = DefaultHeaders; | ||
| HeaderMap headers = JsonContentTypeHeaders; |
Contributor
There was a problem hiding this comment.
Please add a note here explaining why we set the content-type even for requests with no body. It will be useful for our future selves!
Contributor
|
Elasticsearch issue that required this fix: elastic/elasticsearch#133408 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
* http2 issue workaround * adding comment
github-actions bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
* http2 issue workaround * adding comment
l-trotta
added a commit
that referenced
this pull request
Aug 25, 2025
l-trotta
added a commit
that referenced
this pull request
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a workaround for a bug which affects empty body requests when sent with the Rest5Client configured to support http2.
The issue was introduced server side by elastic/elasticsearch#129302 and results in empty body requests causing the following exception:
Invalid media-type value on headers [Accept, Content-Type].(bonus: log fixes for Rest5Client)