Skip to content

Drop support for Python 3.8#3001

Merged
miguelgrinberg merged 4 commits intoelastic:mainfrom
miguelgrinberg:drop-3.8
Jul 25, 2025
Merged

Drop support for Python 3.8#3001
miguelgrinberg merged 4 commits intoelastic:mainfrom
miguelgrinberg:drop-3.8

Conversation

@miguelgrinberg
Copy link
Contributor

No description provided.

@miguelgrinberg miguelgrinberg force-pushed the drop-3.8 branch 2 times, most recently from e1faa21 to b1987fa Compare July 24, 2025 18:30
@miguelgrinberg miguelgrinberg marked this pull request as ready for review July 24, 2025 18:45
@miguelgrinberg miguelgrinberg requested a review from pquentin July 24, 2025 18:45
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git grep 3\\.8 gives other things to change:

docs/reference/getting-started.md:* [Python](https://www.python.org/) 3.8 or newer
examples/fastapi-apm/dockerfiles/Dockerfile.app:FROM python:3.8
examples/fastapi-apm/dockerfiles/Dockerfile.ping:FROM python:3.8
utils/dsl-generator.py:                    # When dropping Python 3.8, use `removesuffix("Function")` instead

Additionally, running pyupgrade --py38-plus **/*.py produces a few more interesting changes.

@github-actions
Copy link

github-actions bot commented Jul 25, 2025

🔍 Preview links for changed docs

@miguelgrinberg miguelgrinberg requested a review from pquentin July 25, 2025 11:41
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg merged commit 14bfbf2 into elastic:main Jul 25, 2025
15 checks passed
@miguelgrinberg miguelgrinberg deleted the drop-3.8 branch July 25, 2025 12:49
@github-actions
Copy link

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-3001-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 14bfbf26a38112df6ba7f058f316a8d123219b39
# Push it to GitHub
git push --set-upstream origin backport-3001-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-3001-to-9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants