Skip to content

[ML] Adding text embedding bit to inference result output #3698

Merged
ymao1 merged 1 commit intomainfrom
ml-support-text-embedding-bits
Feb 4, 2025
Merged

[ML] Adding text embedding bit to inference result output #3698
ymao1 merged 1 commit intomainfrom
ml-support-text-embedding-bits

Conversation

@ymao1
Copy link
Contributor

@ymao1 ymao1 commented Feb 4, 2025

In elastic/elasticsearch#120751, added text_embedding_bits as an output field to store binary embeddings from the Cohere inference API. Although the field name is different, the type is the same as text_embedding_bytes because Cohere returns binary embeddings encoded as bytes with int8 precision.

@ymao1 ymao1 self-assigned this Feb 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete Missing test Missing test
inference.get 🟢 1/1 1/1
inference.inference Missing test Missing test
inference.put Missing test Missing test
inference.stream_inference Missing test Missing test
inference.unified_inference Missing test Missing test
inference.update Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@ymao1 ymao1 marked this pull request as ready for review February 4, 2025 16:49
@ymao1 ymao1 merged commit 65b0fba into main Feb 4, 2025
9 of 10 checks passed
@ymao1 ymao1 deleted the ml-support-text-embedding-bits branch February 4, 2025 17:47
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
pquentin pushed a commit that referenced this pull request Feb 6, 2025
* [DOCS] Fix overlay for resolve cluster (#3670)

* Update specification output

* uppercase enum source mode (#3676)

* [DOCS] Add overlays for CCR API examples (#3672)

* Update inference.update.json with the correct verb (#3688)

* Update specification output

* [DOCS] Convert final examples from JSON to YAML (#3692)

* Update specification output

* Correcting the response format for ingest simulate (#3640)

* Correcting the response format for ingest simulate

* code review feedback

* moving error to the correct place, and adding ignored_fields

* Update specification/simulate/ingest/SimulateIngestResponse.ts

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>

---------

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>

* Update specification output

* Add text_embedding_bits to inference result output (#3698)

* Update specification output

* Improve `Analyzer` definitions and fix various classes (#3215)

* Update specification output

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Co-authored-by: David Kyle <david.kyle@elastic.co>
Co-authored-by: Keith Massey <keith.massey@elastic.co>
Co-authored-by: Ying Mao <ying.mao@elastic.co>
pquentin pushed a commit that referenced this pull request Feb 26, 2025
(cherry picked from commit 65b0fba)

Co-authored-by: Ying Mao <ying.mao@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment