Adds new embedding_type values to PUT Cohere inference endpoint#4403
Adds new embedding_type values to PUT Cohere inference endpoint#4403
embedding_type values to PUT Cohere inference endpoint#4403Conversation
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
| /** | ||
| * For a `text_embedding` task, the types of embeddings you want to get back. | ||
| * Use `binary` for binary embeddings, which are encoded as bytes with signed int8 precision. | ||
| * Use `bit` for binary embeddings, which are encoded as bytes with signed int8 precision (this is a synonym of `binary`). |
There was a problem hiding this comment.
You'll also want to add these two new values to the enum CohereEmbeddingType list a bit further down in the file so that they are treated as valid options in code generated from the spec.
There was a problem hiding this comment.
Hi @JoshMock, I picked this up since @szabosteve is out this week. I’ve updated the PR based on your suggestion - could you please take a look and approve it if everything looks good?
There was a problem hiding this comment.
Looks good! Thanks for adding that.
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
) * Adds new embedding_type values to PUT Cohere inference endpoint. * Adds values to the CohereEmbeddingType enum --------- Co-authored-by: kosabogi <105062005+kosabogi@users.noreply.github.com> Co-authored-by: kosabogi <boglarka.kosa@elastic.co> (cherry picked from commit dc80ba5)
|
@szabosteve is this also supposted to be backported to 9.0? |
) * Adds new embedding_type values to PUT Cohere inference endpoint. * Adds values to the CohereEmbeddingType enum --------- Co-authored-by: kosabogi <105062005+kosabogi@users.noreply.github.com> Co-authored-by: kosabogi <boglarka.kosa@elastic.co> (cherry picked from commit dc80ba5)
) (#4432) * Adds new embedding_type values to PUT Cohere inference endpoint. * Adds values to the CohereEmbeddingType enum --------- (cherry picked from commit dc80ba5) Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com> Co-authored-by: kosabogi <105062005+kosabogi@users.noreply.github.com> Co-authored-by: kosabogi <boglarka.kosa@elastic.co> Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
) (#4419) * Adds new embedding_type values to PUT Cohere inference endpoint. * Adds values to the CohereEmbeddingType enum --------- (cherry picked from commit dc80ba5) Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com> Co-authored-by: kosabogi <105062005+kosabogi@users.noreply.github.com> Co-authored-by: kosabogi <boglarka.kosa@elastic.co> Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
|
@l-trotta No, it's only for 9.1 and 8.19. I'll revert the 9.0 backport in a bit if you don't mind. And thanks for your help! |
Overview
Related to elastic/docs-content#310
Two new embedding types are supported via elastic/elasticsearch#120751. This PR expands the
embedding_typevalue description of the PUT Cohere inference endpoint to reflect the changes.