Skip to content

Revert "[Backport 9.0] Adds new embedding_type values to PUT Cohere inference endpoint"#4438

Merged
szabosteve merged 1 commit into9.0from
revert-4432-backport-4403-to-9.0
Jun 2, 2025
Merged

Revert "[Backport 9.0] Adds new embedding_type values to PUT Cohere inference endpoint"#4438
szabosteve merged 1 commit into9.0from
revert-4432-backport-4403-to-9.0

Conversation

@szabosteve
Copy link
Contributor

Reverts #4432

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.chat_completion_unified Missing test Missing test
inference.completion Missing test Missing test
inference.delete Missing test Missing test
inference.get 🟢 1/1 1/1
inference.inference Missing test Missing test
inference.put_alibabacloud Missing test Missing test
inference.put_amazonbedrock Missing test Missing test
inference.put_anthropic Missing test Missing test
inference.put_azureaistudio Missing test Missing test
inference.put_azureopenai Missing test Missing test
inference.put_cohere Missing test Missing test
inference.put_elasticsearch Missing test Missing test
inference.put_elser Missing test Missing test
inference.put_googleaistudio Missing test Missing test
inference.put_googlevertexai Missing test Missing test
inference.put_hugging_face Missing test Missing test
inference.put_jinaai Missing test Missing test
inference.put_mistral Missing test Missing test
inference.put_openai Missing test Missing test
inference.put_voyageai Missing test Missing test
inference.put_watsonx Missing test Missing test
inference.put Missing test Missing test
inference.rerank Missing test Missing test
inference.sparse_embedding Missing test Missing test
inference.stream_completion Missing test Missing test
inference.text_embedding Missing test Missing test
inference.update Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@flobernd
Copy link
Member

flobernd commented Jun 2, 2025

@szabosteve What's the reason for reverting this change? Is it 9.1+ only? Just asking because I released a new client version today and it seems to contain this change 😅

@szabosteve
Copy link
Contributor Author

szabosteve commented Jun 2, 2025

@flobernd Yes, it's a 9.1 (and 8.19) change, so it's not released yet.
This is the corresponding issue: elastic/docs-content#310
Which refers to the dev PR: elastic/elasticsearch#120751, the tags on that PR also state 9.1 and 8.19.

@szabosteve szabosteve merged commit 707cbdd into 9.0 Jun 2, 2025
7 checks passed
@szabosteve szabosteve deleted the revert-4432-backport-4403-to-9.0 branch June 2, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants