-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Closed
Labels
:Analytics/ES|QLAKA ESQLAKA ESQL>bug>tech-debtTeam:AnalyticsMeta label for analytical engine team (ESQL/Aggs/Geo)Meta label for analytical engine team (ESQL/Aggs/Geo)
Description
This helper method is used in type checks/resolutions and checks whether a value is not null.
This check really shouldn't happen at the time when we perform type resolutions - type resolutions shouldn't depend on individual values.
More importantly, folding values can be expensive - we should only perform this in the ConstantFolding and FoldNulls steps of the logical optimizer.
We may be able to use the Validatable (update: now PostOptimizationVerificationAware) interface to perform the null-check after the logical optimizer step, when all foldables can be assumed to be already folded.
This is currently used in Top, FullTextFunction and Match.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
:Analytics/ES|QLAKA ESQLAKA ESQL>bug>tech-debtTeam:AnalyticsMeta label for analytical engine team (ESQL/Aggs/Geo)Meta label for analytical engine team (ESQL/Aggs/Geo)