Break on FieldData when building global ordinals#108875
Merged
iverase merged 10 commits intoelastic:mainfrom Nov 24, 2025
Merged
Break on FieldData when building global ordinals#108875iverase merged 10 commits intoelastic:mainfrom
iverase merged 10 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @iverase, I've created a changelog YAML for you. |
Member
|
I think this is the right thing to do, but:
|
… into globalOrdinalBreak
Member
|
This seems like the safe thing to do. Why wouldn't we want to check the CB on ordinal creation to protect users? |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
Member
|
@iverase Did we want to pursue this one? |
Contributor
Author
|
@elasticmachine please test this |
iverase
added
branch:9.2
branch:9.1
branch:8.19
auto-backport
elasticsearchmachine
added
v9.2.2
v8.19.8
v9.1.8
and removed
branch:9.2
branch:9.1
branch:8.19
labels
This was referenced Nov 24, 2025
Collaborator
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Nov 24, 2025
This commit adds the bytes and break if we get over the limit of the breaker when building global ordinals.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Nov 24, 2025
This commit adds the bytes and break if we get over the limit of the breaker when building global ordinals.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Nov 24, 2025
This commit adds the bytes and break if we get over the limit of the breaker when building global ordinals.
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Nov 24, 2025
This commit adds the bytes and break if we get over the limit of the breaker when building global ordinals.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 24, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 24, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 24, 2025
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Nov 26, 2025
This commit adds the bytes and break if we get over the limit of the breaker when building global ordinals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when building global ordinals, we add to the breaker the size of the final object without breaking. I think the reason for not breaking is that it makes little sense to break at that point if we already build the object. The side effect is that we don't honour the breaker limit which is equally bad.
Therefore this commit proposes to add the bytes and break if we get over the limit of the breaker. the side effect is that working cluster might be hitting this breaker now. Still not honouring a limit should be considered a bug.
closes #97075