Updated Date Range to Follow Documentation When Assuming Missing Values

[john-wagster]

Based on a review of the documentation here: https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-range-query.html. Our behavior at query and index time for date range queries was inconsistent.

This would lead to what was discovered here: #111484 where an indexed date_range field like the one shown below would not be returned by the exact same query shown below.

I attempted to fix this by changing the query parser to use DateMathParser which rounds appropriately to what's documented above. This changes missing information in date time values to be inline with the documentation often by 1 millisecond (such as the time information in the below example).

A few concerns worth discussing with this are where this should land in terms of releases and impacts to customer who may have assumptions about how date range has been working up to this point. Opening this as a discussion with some caution around putting it in until we get appropriate feedback.

query example

PUT /test_index1?pretty
{
    "mappings" : {
        "properties" : {
            "opening_dates": {
              "type": "date_range",
              "format": "yyyy-MM-dd"
            }
        }
    }
}

PUT test_index1/_doc/7
{
    "opening_dates": [
    {
      "gte": "2014-09-18",
      "lte": "2016-12-18"
    }
  ]
}

GET test_index1/_search
{
  "explain": true, 
  "query": {
    "bool": {
      "must": [
        {
          "range": {
            "opening_dates": {
              "gte": "2014-09-18",
              "lte": "2016-12-18",
              "relation": "contains",
              "format": "yyyy-MM-dd"
            }
          }
        }
      ]
    }
  }
}

[elasticsearchmachine]

Pinging @elastic/es-search-relevance (Team:Search Relevance)

[elasticsearchmachine]

Hi @john-wagster, I've created a changelog YAML for you.

[elasticsearchmachine]

Hi @john-wagster, I've updated the changelog YAML for you.

[benwtrent]

//cc @elastic/es-core-infra

This does seem like the way it should have always been for range values :/ wanting to make sure we aren't doing something crazy.

[elasticsearchmachine]

Pinging @elastic/es-search-foundations (Team:Search Foundations)

[elasticsearchmachine]

Hi @john-wagster, I've updated the changelog YAML for you.

[elasticsearchmachine]

Hi @john-wagster, I've updated the changelog YAML for you.

[john-wagster]

@elasticsearchmachine test this please

[thecoop]

This can be a test feature I think...

[john-wagster]

Wasn't sure about when to use test featuers or not; thanks for the suggestion. Let me know if that's not what you were thinking.

[elasticsearchmachine]

Hi @john-wagster, I've updated the changelog YAML for you.