[plugin/apm-data] Use component-templates to configure fallback to ILM#112432
Merged
lahsivjar merged 1 commit intoelastic:8.15from Sep 2, 2024
Merged
[plugin/apm-data] Use component-templates to configure fallback to ILM#112432lahsivjar merged 1 commit intoelastic:8.15from
lahsivjar merged 1 commit intoelastic:8.15from
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
axw
approved these changes
Sep 2, 2024
Member
axw
left a comment
There was a problem hiding this comment.
LGTM. When we come to addressing the issue on main, we should add a YAML REST test that ensures we don't regress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves fallback for ILM to component templates which will allow users to override DSL configurations as required even for versions > 8.15.0
PR is tested: elastic/apm-server#13898 (comment)