Skip to content

#104411 Add warning headers for ingest pipelines containing special characters#114837

Merged
lukewhiting merged 7 commits intoelastic:mainfrom
lukewhiting:104411-disallow-chars-in-pipeline-names
Oct 16, 2024
Merged

#104411 Add warning headers for ingest pipelines containing special characters#114837
lukewhiting merged 7 commits intoelastic:mainfrom
lukewhiting:104411-disallow-chars-in-pipeline-names

Conversation

@lukewhiting
Copy link
Contributor

@lukewhiting lukewhiting commented Oct 15, 2024

This PR adds a warning header when attempting to create an ingest pipeline with invalid characters in the name.

@lukewhiting lukewhiting requested a review from a team October 15, 2024 14:04
@lukewhiting lukewhiting added >bug >breaking :Distributed/Ingest Node Execution or management of Ingest Pipelines v9.0.0 labels Oct 15, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Oct 15, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @lukewhiting, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

@elasticsearchmachine
Copy link
Collaborator

Hi @lukewhiting, I've updated the changelog YAML for you.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Luke!

@lukewhiting lukewhiting merged commit 64e8659 into elastic:main Oct 16, 2024
@lukewhiting lukewhiting deleted the 104411-disallow-chars-in-pipeline-names branch October 16, 2024 07:58
javanna pushed a commit to javanna/elasticsearch that referenced this pull request Oct 16, 2024
…ecial characters (elastic#114837)

* Add logs and headers

For pipeline creation when name is invalid

* Fix YAML tests and add YAML test for warnings

* Update docs/changelog/114837.yaml

* Changelog entry

* Changelog entry

* Update docs/changelog/114837.yaml

* Changelog entry
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
…ecial characters (elastic#114837)

* Add logs and headers

For pipeline creation when name is invalid

* Fix YAML tests and add YAML test for warnings

* Update docs/changelog/114837.yaml

* Changelog entry

* Changelog entry

* Update docs/changelog/114837.yaml

* Changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Distributed/Ingest Node Execution or management of Ingest Pipelines Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v9.0.0

3 participants