Fix double lookup failure on ESQL#115616
Merged
alex-spies merged 5 commits intoelastic:mainfrom Nov 22, 2024
Merged
Conversation
Contributor
Author
|
Can someone help me assign some labels? |
# Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/physical/HashJoinExec.java
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Nov 22, 2024
Contributor
There was a problem hiding this comment.
Thanks a lot for your contribution, @jackpan123, nice find!
The fix looks good to me. We will not be able to close #111398 with this, though. Because we'd have to add tests to avoid regressions in the future - but more importantly because LOOKUP is still under development and currently changing a lot, so that the corresponding tests are disabled right now.
Contributor
|
@elasticsearchmachine test this please |
Contributor
|
@elasticsearchmachine generate changelog |
Contributor
|
@elasticsearchmachine test this please |
Collaborator
💚 Backport successful
|
alex-spies
pushed a commit
to alex-spies/elasticsearch
that referenced
this pull request
Nov 22, 2024
Fix a bug in HashJoinExec.addedFields that caused multiple LOOKUPs in a query to fail.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 22, 2024
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Nov 22, 2024
Fix a bug in HashJoinExec.addedFields that caused multiple LOOKUPs in a query to fail.
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Fix a bug in HashJoinExec.addedFields that caused multiple LOOKUPs in a query to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix double lookup failure on ESQL (Closes #111398 ).
I also try three times LOOKUP, it is fine, result like below: