Don't allow secure settings in YML config (109115)#115779
Merged
alexey-ivanov-es merged 3 commits intoelastic:mainfrom Nov 4, 2024
Merged
Don't allow secure settings in YML config (109115)#115779alexey-ivanov-es merged 3 commits intoelastic:mainfrom
alexey-ivanov-es merged 3 commits intoelastic:mainfrom
Conversation
Elasticsearch should refuse to start if a secure setting is defined in elasticsearch.yml, in order to protect users from accidentally putting their secrets in a place where they are unexpectedly visible Fixes elastic#109115
alexey-ivanov-es
added
>bug
:Core/Infra/Settings
Collaborator
|
Hi @alexey-ivanov-es, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
DaveCTurner
previously requested changes
Nov 4, 2024
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Hang on, I think this is a breaking change, we need to clear it with the breaking changes committee first and document it as breaking. I suspect we should be emitting warnings in 8.x as well to help folks avoid the problem before it actually takes effect.
Contributor
Author
|
@DaveCTurner I discussed this with @rjernst and he said: "I confirmed that we are ok to proceed with the above change. it's an edge case which is in a gray area we shouldn't need an explicit breaking change issue for." |
Contributor
|
Ok carry on then. |
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
* Don't allow secure settings in YML config (109115) Elasticsearch should refuse to start if a secure setting is defined in elasticsearch.yml, in order to protect users from accidentally putting their secrets in a place where they are unexpectedly visible Fixes #109115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elasticsearch should refuse to start
if a secure setting is defined in elasticsearch.yml, in order to protect users from accidentally putting their secrets in a place where they are unexpectedly visible
Fixes #109115