Skip to content

Fix leak in DfsQueryPhase and introduce search disconnect stress test#116060

Merged
original-brownbear merged 2 commits intoelastic:mainfrom
original-brownbear:fix-last-leak
Nov 1, 2024
Merged

Fix leak in DfsQueryPhase and introduce search disconnect stress test#116060
original-brownbear merged 2 commits intoelastic:mainfrom
original-brownbear:fix-last-leak

Conversation

@original-brownbear
Copy link
Contributor

Fixing an obvious leak and finally adding a stress test for search disconnects.

closes #115056

Fixing an obvious leak and finally adding a stress test for search
disconnects.
@original-brownbear original-brownbear added >bug :Search Foundations/Search Catch all for Search Foundations labels Nov 1, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine elasticsearchmachine added v9.0.0 Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Nov 1, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @original-brownbear, I've created a changelog YAML for you.

Copy link
Contributor

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops, the fix looks correct to me.

@original-brownbear original-brownbear added the auto-backport Automatically create backport pull requests when merged label Nov 1, 2024
@original-brownbear
Copy link
Contributor Author

Thanks Luca!

@original-brownbear original-brownbear merged commit 38acee9 into elastic:main Nov 1, 2024
@original-brownbear original-brownbear deleted the fix-last-leak branch November 1, 2024 13:26
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 116060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.17.0 v9.0.0

3 participants