Skip to content

Handle with illegalArgumentExceptions negative values in HDR percentile aggregations#116174

Merged
iverase merged 8 commits intoelastic:mainfrom
iverase:hdrpercentiles
Nov 5, 2024
Merged

Handle with illegalArgumentExceptions negative values in HDR percentile aggregations#116174
iverase merged 8 commits intoelastic:mainfrom
iverase:hdrpercentiles

Conversation

@iverase
Copy link
Contributor

@iverase iverase commented Nov 4, 2024

We are currently throwing an ArrayIndexOutOfBoundsException which traduces into a server internal error. This commit changes to an illegalArgumentException which translate in a bad request (400).

fixes #115777

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @iverase, I've created a changelog YAML for you.

Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase added the auto-backport Automatically create backport pull requests when merged label Nov 5, 2024
@iverase iverase merged commit c253a14 into elastic:main Nov 5, 2024
@iverase iverase deleted the hdrpercentiles branch November 5, 2024 14:31
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.16 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 116174

jozala pushed a commit that referenced this pull request Nov 13, 2024
…le aggregations (#116174)

This commit changes to an illegalArgumentException which translate in a bad request (400).
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
…le aggregations (elastic#116174)

This commit changes to an illegalArgumentException which translate in a bad request (400).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations auto-backport Automatically create backport pull requests when merged >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.0.0

4 participants