Skip to content

Removing index alias creation for deprecated transforms notification index#117583

Merged
dan-rubinstein merged 5 commits intoelastic:mainfrom
dan-rubinstein:consolidate-notification-indices
Dec 11, 2024
Merged

Removing index alias creation for deprecated transforms notification index#117583
dan-rubinstein merged 5 commits intoelastic:mainfrom
dan-rubinstein:consolidate-notification-indices

Conversation

@dan-rubinstein
Copy link
Member

@dan-rubinstein dan-rubinstein commented Nov 26, 2024

Issue - https://github.com/elastic/ml-team/issues/1391

Description

In 8.x, notification indices were migrated from .data-frame-notifications-1 to .transform-notifications-000002. Extra logic was added to create an index alias from .data-frame-notifications-1 to .transform-notifications-read which is called by kibana and users to read the notification data. If a users is running on 7.x, the current guidance is to upgrade to 8.x, which will create the necessary alias and stop writing to the old notification index. We should be safe from there to stop creating the alias in the cluster listener and delete all code references in 9.x. This change deletes the alias creation logic and any remaining references to the old notification index in code.

[MERGE BLOCKER] Note: This change is blocked on the approval of the breaking change request. This change can not be merged until the breaking change request is approved.
Note [Updated]: The breaking change request has now been approved so this change does not have any more merge blockers.

Testing

  • Unit tests
  • Ran elasticsearch locally, created a transform and found .transform-notifications-000002 was still created with the following alias:
.transform-notifications-000002": {
        "aliases": {
            ".transform-notifications-read": {
                "is_hidden": true
            }
        }
    }

And no references to .data-frame-notifications-1 exist.

@dan-rubinstein dan-rubinstein added >deprecation :ml Machine learning Team:ML Meta label for the ML team v9.0.0 labels Nov 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @dan-rubinstein, I've created a changelog YAML for you. Note that since this PR is labelled >deprecation, you need to update the changelog YAML to fill out the extended information sections.

@dan-rubinstein dan-rubinstein marked this pull request as ready for review December 2, 2024 19:40
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@dan-rubinstein
Copy link
Member Author

@elasticmachine merge upstream

@dan-rubinstein dan-rubinstein merged commit d839205 into elastic:main Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>deprecation :ml Machine learning Team:ML Meta label for the ML team v9.0.0

4 participants