Removing index alias creation for deprecated transforms notification index#117583
Merged
dan-rubinstein merged 5 commits intoelastic:mainfrom Dec 11, 2024
Merged
Conversation
Collaborator
|
Hi @dan-rubinstein, I've created a changelog YAML for you. Note that since this PR is labelled |
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
approved these changes
Dec 10, 2024
Member
Author
|
@elasticmachine merge upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue - https://github.com/elastic/ml-team/issues/1391
Description
In 8.x, notification indices were migrated from
.data-frame-notifications-1to.transform-notifications-000002. Extra logic was added to create an index alias from.data-frame-notifications-1to.transform-notifications-readwhich is called by kibana and users to read the notification data. If a users is running on 7.x, the current guidance is to upgrade to 8.x, which will create the necessary alias and stop writing to the old notification index. We should be safe from there to stop creating the alias in the cluster listener and delete all code references in 9.x. This change deletes the alias creation logic and any remaining references to the old notification index in code.[MERGE BLOCKER] Note: This change is blocked on the approval of the breaking change request. This change can not be merged until the breaking change request is approved.Note [Updated]: The breaking change request has now been approved so this change does not have any more merge blockers.
Testing
.transform-notifications-000002was still created with the following alias:And no references to
.data-frame-notifications-1exist.