[ML] Remove deprecated sort from reindex operation#117606
Merged
edsavage merged 6 commits intoelastic:mainfrom Nov 28, 2024
Merged
[ML] Remove deprecated sort from reindex operation#117606edsavage merged 6 commits intoelastic:mainfrom
edsavage merged 6 commits intoelastic:mainfrom
Conversation
Sort in reindex is deprecated. This PR naively removes its use from within the reindexing step of dataframe analytics. Although this doesn't appear to have broken fundamental functionality, creating this PR as a draft initially to smoke out any unforeseen consequences.
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @edsavage, I've created a changelog YAML for you. Note that since this PR is labelled |
Collaborator
|
Hi @edsavage, I've updated the changelog YAML for you. |
valeriy42
approved these changes
Nov 28, 2024
Contributor
valeriy42
left a comment
valeriy42
left a comment
There was a problem hiding this comment.
LGTM. Good work finding it! 🚀
edsavage
added a commit
to edsavage/elasticsearch
that referenced
this pull request
Nov 28, 2024
Sort in reindex is deprecated. This PR removes its use from within the reindexing step of dataframe analytics. Testing indicates that having the destination index sorted is a "nice to have" and not necessary for the DFA functionality to succeed.
edsavage
added a commit
that referenced
this pull request
Nov 29, 2024
Sort in reindex is deprecated. This PR removes its use from within the reindexing step of dataframe analytics. Testing indicates that having the destination index sorted is a "nice to have" and not necessary for the DFA functionality to succeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort in reindex is deprecated. This PR removes its use from within the reindexing step of dataframe analytics.
Testing indicates that having the destination index sorted is a "nice to have" and not necessary for the DFA functionality to succeed.