fix/SearchStatesIt_failures#117618
Conversation
drempapis
added
>bug
Team:Search Foundations
|
Hi @drempapis, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
@javanna Is this approach enough to merge the muted tests for v9.0.0 and v8.18.0? |
| } | ||
|
|
||
| public static void configureRemoteClusters(List<Node> remoteNodes) throws Exception { | ||
| assertThat(remoteNodes, hasSize(3)); |
There was a problem hiding this comment.
I don't think assertBusy will help you here? The list is just created one by a call to getNodes(.. so it won't ever change?
There was a problem hiding this comment.
You are right. I added the ensureHealth with a timeout to verify that all three nodes are up and running before requesting the nodes' state.
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, if CI's happy I'm happy :) thanks!
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
One second I'm a little unsure here, discussing in Slack
|
In this pr #116577, the |
drempapis
added
the
auto-backport
|
Hi @drempapis, I've updated the changelog YAML for you. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
This will backport the following commits from main to 8.x: #117618
|
We manually backported changes to v8.18.0 #117729 |
3 participants
It seems that there is a race condition where this call does not pick up all three nodes that this assert is expecting.
To mitigate and test the issue, I added an "assertBusy" busy spin in the nodes lookup, waiting until all three nodes appear.
Solves #116617 and #116618