Merged
Conversation
mhl-b
added
>test
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
mhl-b
added
the
auto-backport
mhl-b
added a commit
to mhl-b/elasticsearch
that referenced
this pull request
Nov 29, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrahsingByteBuf #116115 does not fully cover derived buffers - slices and copies. This PR wraps all dervied buffers into TrashingByteBuf.
It's not a problem when HTTP aggregator is used, since it will allocate TrashingCompositeByteBuf. But non aggregated parts, like HttpContent, are created using derived buffers, these will not trash. For example here: https://github.com/netty/netty/blob/225adacc2da02403640435ca53cfce9bf78995bf/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java#L439