SearchServiceTests.testParseSourceValidation failure#117963
Merged
drempapis merged 10 commits intoelastic:mainfrom Dec 5, 2024
Merged
SearchServiceTests.testParseSourceValidation failure#117963drempapis merged 10 commits intoelastic:mainfrom
drempapis merged 10 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Collaborator
|
Hi @drempapis, I've created a changelog YAML for you. |
…e' of github.com:drempapis/elasticsearch into fix/SearchServiceTests.testParseSourceValidation_failure
javanna
reviewed
Dec 4, 2024
| ); | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I think that you can delete the assertCreateContextValidation method too
Contributor
|
Don't forget to close #115936 once this gets merged ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has been failing due to #113081, which deleted the incoming search validation on the data node for bwc.
In this work, #105150, validation has been moved to the coordinate nodes. The following is a matrix of the validation Exception messages of the
SearchServicemoving toSearchRequest, including a test creation checking.