Smarter field caps with subscribable listener (#116755)#118063
Merged
elasticsearchmachine merged 2 commits intoelastic:8.xfrom Dec 5, 2024
Merged
Smarter field caps with subscribable listener (#116755)#118063elasticsearchmachine merged 2 commits intoelastic:8.xfrom
elasticsearchmachine merged 2 commits intoelastic:8.xfrom
Conversation
(cherry picked from commit 22f4a79)
…stic#118015) the mapping will not contain the "value" field (cherry picked from commit 774c6ea)
astefan
added
>enhancement
backport
auto-merge-without-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is two fold:
refactors EsqlSession to use (hopefully) a more readable and manageable series of async calls that start with pre-analysis of enrich policies, regular indices, lookup indices and end with verification of the analyzed logical plan of the query. It's changing the nested calls using ActionListeners to a "flat" series of steps using SubscribableListener
in case of VerificationException being thrown in the verification step (following the analysis of the logical plan) and given a REST request filter was used, it removes the filter and retries the analysis. Assuming the first call to IndexResolver using the filter (and implicitly to _field_caps call where the filter is being used, as well) fails, it's retries the _field_caps call without a filter.
There is a leftover task (to be addressed in a separate PR) that should add tests in CCS scenarios: #118054
Addresses #115053
Backport of #116755