Update data stream deprecations warnings to new format and filter searchable snapshots from response#118562
Merged
lukewhiting merged 13 commits intoelastic:mainfrom Dec 19, 2024
Conversation
lukewhiting
added
:StorageEngine/Data streams
lukewhiting
force-pushed
the
additional-migration-info-for-ds-reindex
branch
2 times, most recently
from
94db41c to
fdfcc44
Compare
lukewhiting
force-pushed
the
additional-migration-info-for-ds-reindex
branch
from
ba12172 to
e02283f
Compare
elasticsearchmachine
added
the
Team:Data Management (obsolete)
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
...precation/src/main/java/org/elasticsearch/xpack/deprecation/DataStreamDeprecationChecks.java
Outdated
Show resolved
Hide resolved
...precation/src/main/java/org/elasticsearch/xpack/deprecation/DataStreamDeprecationChecks.java
Outdated
Show resolved
Hide resolved
…al-migration-info-for-ds-reindex
…al-migration-info-for-ds-reindex
Contributor
Author
|
Note to self: Add on hiding searchable snapshots from the deprecations API (DS and regular index) and from the migrations API |
lukewhiting
commented
Dec 18, 2024
| return new DeprecationIssue( | ||
| DeprecationIssue.Level.CRITICAL, | ||
| "Old data stream with a compatibility version < 8.0", | ||
| "Old data stream with a compatibility version < 9.0", |
Contributor
Author
There was a problem hiding this comment.
I have updated the wording here. Is this correct for 9.0 (Main)? I'm guessing it will need changing back for the backport?
Member
There was a problem hiding this comment.
Yeah for main it is correct (for now -- who knows what will be correct when we actually get to 10.0), and for 8.x it'll need to read < 8.0.
lukewhiting
commented
Dec 18, 2024
| } | ||
|
|
||
| private static boolean creationVersionBeforeMinimumWritableVersion(IndexMetadata metadata) { | ||
| return metadata.getCreationVersion().before(MINIMUM_WRITEABLE_VERSION_AFTER_UPGRADE); |
Contributor
Author
There was a problem hiding this comment.
Previously this was onOrBefore but I think before is correct here in that you can write to the minimum version so should not result in a warning or migration?
Collaborator
|
Hi @lukewhiting, I've created a changelog YAML for you. |
Contributor
Author
|
@masseyke @parkertimmins Have pushed up the changes we discussed yesterday RE @dakrone asking us to filter snapshots and centralising the predicate. |
…al-migration-info-for-ds-reindex
masseyke
reviewed
Dec 18, 2024
...in/migrate/src/main/java/org/elasticsearch/xpack/migrate/action/ReindexDataStreamAction.java
Outdated
Show resolved
Hide resolved
lukewhiting
removed
the
auto-backport
…al-migration-info-for-ds-reindex
…al-migration-info-for-ds-reindex
lukewhiting
added a commit
to lukewhiting/elasticsearch
that referenced
this pull request
Dec 19, 2024
…rchable snapshots from response (elastic#118562) * Update data stream deprecations warnings to new format * Add reindex_required flag to index version deprecation notice response * PR Changes * Move all deprecation checks to use a shared predicate which also excludes snapshots * Update docs/changelog/118562.yaml * Tests for excluding snapshots * PR Changes - Remove leftover comment (cherry picked from commit 5487927)
lukewhiting
added a commit
that referenced
this pull request
Dec 19, 2024
…er sea… (#119097) * Update data stream deprecations warnings to new format and filter searchable snapshots from response (#118562) * Update data stream deprecations warnings to new format * Add reindex_required flag to index version deprecation notice response * PR Changes * Move all deprecation checks to use a shared predicate which also excludes snapshots * Update docs/changelog/118562.yaml * Tests for excluding snapshots * PR Changes - Remove leftover comment (cherry picked from commit 5487927) * Update docs/changelog/119097.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
DataStreamDeprecationChecksclass and it's corresponding test class to implement the metadata format requested by Kibana to assist in making the cluster upgrade process smoother.It also makes the following smaller changes:
reindex_requiredflag to the non Data Streams index migration warning.