Fix synthetic recovery source version validation.#118924
Merged
martijnvg merged 5 commits intoelastic:mainfrom Dec 18, 2024
Merged
Fix synthetic recovery source version validation.#118924martijnvg merged 5 commits intoelastic:mainfrom
martijnvg merged 5 commits intoelastic:mainfrom
Conversation
The validation didn't work as expected, because created version was always `0` (which is created version default value). I think we actually don't need the versioning added in elastic#114618. This is a final setting and only clusters on the version that understand the use_synthetic_source can set it. Looking at this differently, this setting can't be set on indices created with earlier versions of Elasticsearch.
martijnvg
added
:StorageEngine/Mapping
martijnvg
added
the
auto-backport
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
jimczi
approved these changes
Dec 18, 2024
| RECOVERY_USE_SYNTHETIC_SOURCE_SETTING.getKey() | ||
| ) | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
Can you also remove SETTING_INDEX_VERSION_CREATED from the settings returned below.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Dec 18, 2024
The validation didn't work as expected, because created version was always 0 (which is created version default value). Moving the validation to a place that does have access to the index version.
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Dec 18, 2024
The validation didn't work as expected, because created version was always 0 (which is created version default value). Moving the validation to a place that does have access to the index version.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Fix synthetic recovery source version validation. (#118924) The validation didn't work as expected, because created version was always 0 (which is created version default value). Moving the validation to a place that does have access to the index version. * fixed compile error after cherry picking * iter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation didn't work as expected, because created version was always
0(which is created version default value).Moving the validation to a place that does have access to the index version.