Connecting the reindex data stream persistent task to ReindexDataStreamIndexAction#118978
Merged
masseyke merged 6 commits intoelastic:mainfrom Dec 18, 2024
Merged
Conversation
masseyke
added
>non-issue
:StorageEngine/Data streams
elasticsearchmachine
added
the
Team:Data Management (obsolete)
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
| List<Index> indices = dataStream.getIndices(); | ||
| List<Index> indicesToBeReindexed = indices.stream() | ||
| .filter(getOldIndexVersionPredicate(clusterService.state().metadata())) | ||
| .filter(index -> index.getName().equals(dataStream.getWriteIndex().getName()) == false) |
Contributor
There was a problem hiding this comment.
Won't this be redundant after the rollover? I though the write index would have a newer version by this point? Maybe this could be an assert instead?
Member
Author
There was a problem hiding this comment.
Oh I think you're right, and that's just some placeholder code I had in before I added the rollover step. I'll remove that filter.
parkertimmins
approved these changes
Dec 18, 2024
Contributor
parkertimmins
left a comment
parkertimmins
left a comment
There was a problem hiding this comment.
Just one small question, otherwise looks good
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Dec 18, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 19, 2024
…amIndexAction (#118978) (#119032) * Connecting the reindex data stream persistent task to ReindexDataStreamIndexAction (#118978) * removing java 21 syntax * [CI] Auto commit changes from spotless * removing java 21 syntax * removing code that doesnt work in 7.17 * expecting no upgrades in clusters of the same major versoin * correcting method name after merge --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This connects the reindex data streams task introduced in #116780 with the actual reindexing logic introduced in #116996. For now, it restricts the task to reindexing a single index at a time, but future work will make this configurable.