Add a replicate_for option to the ILM searchable_snapshot action#119003
Merged
joegallo merged 30 commits intoelastic:mainfrom Jan 27, 2025
Merged
Add a replicate_for option to the ILM searchable_snapshot action#119003joegallo merged 30 commits intoelastic:mainfrom
joegallo merged 30 commits intoelastic:mainfrom
Conversation
joegallo
added
>enhancement
WIP
:Data Management/ILM+SLM
dakrone
reviewed
Dec 23, 2024
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
Provisionally looks good to me!
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleType.java
Show resolved
Hide resolved
...core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitUntilReplicateForTimePassesStep.java
Outdated
Show resolved
Hide resolved
It shouldn't ever happen, but ever is a long time.
and add tests of the validation logic
and update the tests. Also, rewrite the tests to correctly delineate actual and expected values (doh!).
It can be null, but if it isn't, then it need to be a positive amount of time (not -1 or 0).
dakrone
approved these changes
Jan 21, 2025
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, are you going to do docs in this PR, or a subsequent one?
Contributor
Author
I'll do them on this PR first thing tomorrow -- thanks for the code review, and I'll ping you for one last look at the docs before I merge this. |
joegallo
force-pushed
the
ilm-searchable-snapshot-replicate-for
branch
from
c19732e to
da09652
Compare
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Contributor
Author
|
@dakrone what do you think of this for the docs? |
Collaborator
|
Hi @joegallo, I've created a changelog YAML for you. |
Contributor
Author
|
CI passed but github missed the update notification, I'm merging this. |
Collaborator
💚 Backport successful
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
replicate_foroption (expressed as a time value) to the ILMsearchable_snapshotaction. If that option is present, then the searchable snapshot will be mounted with one replica (rather than zero replicas), and ILM execution will wait in the searchable snapshot action until thereplicate_fortime value has passed. Once the time value has passed, then the replica will be removed and execution will continue.As an example, this makes it possible to have a
frozenphase that lasts for 60 days, but to have 14 days worth of frozen data mounted with replicas.