Metrics for indexing failures due to version conflicts#119067
Merged
albertzaharovits merged 44 commits intoelastic:mainfrom Jan 8, 2025
Merged
Metrics for indexing failures due to version conflicts#119067albertzaharovits merged 44 commits intoelastic:mainfrom
albertzaharovits merged 44 commits intoelastic:mainfrom
Conversation
Contributor
|
@albertzaharovits please tell me when this is ready for review again, thanks! |
Collaborator
|
Hi @albertzaharovits, I've created a changelog YAML for you. |
Contributor
Author
|
@kingherc this is now ready for another round. |
kingherc
approved these changes
Jan 7, 2025
Contributor
kingherc
left a comment
kingherc
left a comment
There was a problem hiding this comment.
Better add auto-backport label to PR.
LGTM, much cleaner!
| { | ||
| var e = expectThrows( | ||
| VersionConflictEngineException.class, | ||
| () -> client(dataNode).index(new IndexRequest("test").id(docId).source(Map.of()).setIfSeqNo(1).setIfPrimaryTerm(1)) |
Contributor
There was a problem hiding this comment.
Is this because the seqno is 0 for the document?
albertzaharovits
added
auto-merge-without-approval
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Jan 8, 2025
This exposes new OTel node and index based metrics for indexing failures due to version conflicts. In addition, the /_cat/shards, /_cat/indices and /_cat/nodes APIs also expose the same metric, under the newly added column iifvc. Relates: elastic#107601 (cherry picked from commit 12eb1cf) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 9, 2025
#119761) * Metrics for indexing failures due to version conflicts (#119067) This exposes new OTel node and index based metrics for indexing failures due to version conflicts. In addition, the /_cat/shards, /_cat/indices and /_cat/nodes APIs also expose the same metric, under the newly added column iifvc. Relates: #107601 (cherry picked from commit 12eb1cf) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java * types * Fix NodeIndexingMetricsIT * [CI] Auto commit changes from spotless * Fix RestShardsActionTests * Fix test/cat.shards/10_basic.yml for bwc --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes new OTel node and index based metrics for indexing failures due to version conflicts.
In addition, the
/_cat/shards,/_cat/indicesand/_cat/nodesAPIs also expose the same metric, under the newly added columniifvc.Relates: #107601