Merged
Conversation
dnhatn
force-pushed
the
row-size-estimate
branch
2 times, most recently
from
2a4debf to
1a44abe
Compare
dnhatn
force-pushed
the
row-size-estimate
branch
from
1a44abe to
a0b4abd
Compare
Collaborator
|
Hi @dnhatn, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
Jan 3, 2025
Member
|
Oh boy! I remember estimating row sizes! Thanks for fixing this! |
dnhatn
added
the
auto-backport
Member
Author
|
Thanks Nik! |
Collaborator
💚 Backport successful
|
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 3, 2025
Currently, we only account for attributes after the TopN operation when estimating its row size. This results in invalid estimates for the final TopN on the coordinator and the node-level reduction TopN. This change corrects the estimates and removes the workaround, paving the way for enabling node-level reduction in ES|QL. Closes elastic#106956
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 3, 2025
Currently, we only account for attributes after the TopN operation when estimating its row size. This results in invalid estimates for the final TopN on the coordinator and the node-level reduction TopN. This change corrects the estimates and removes the workaround, paving the way for enabling node-level reduction in ES|QL. Closes #106956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we only account for attributes after the TopN operation when estimating its row size. This results in invalid estimates for the final TopN on the coordinator and the node-level reduction TopN. This change corrects the estimates and removes the workaround, paving the way for enabling node-level reduction in ES|QL.
Closes #106956