Run TransportClusterGetSettingsAction on local node#119831
Merged
nielsbauman merged 5 commits intoelastic:mainfrom Jan 14, 2025
Merged
Run TransportClusterGetSettingsAction on local node#119831nielsbauman merged 5 commits intoelastic:mainfrom
TransportClusterGetSettingsAction on local node#119831nielsbauman merged 5 commits intoelastic:mainfrom
Conversation
This action solely needs the cluster state, it can run on any node. Additionally, it needs to be cancellable to avoid doing unnecessary work after a client failure or timeout.
nielsbauman
added
>enhancement
:Core/Infra/Settings
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @nielsbauman, I've created a changelog YAML for you. |
Contributor
Author
|
I initially mistakenly thought Data Management owned this API but I just realized we don't. Since I had the changes already, I just opened a PR anyway. |
45 tasks
ldematte
approved these changes
Jan 13, 2025
Contributor
ldematte
left a comment
ldematte
left a comment
There was a problem hiding this comment.
Changes look good, and I follow your reasoning why this can run on any node as everything is read from state.metadata. There might have been some undocumented/unrelated reasons why this should have run on a master, but I cannot think of any.
martijnvg
pushed a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jan 14, 2025
This action solely needs the cluster state, it can run on any node. Additionally, it needs to be cancellable to avoid doing unnecessary work after a client failure or timeout. The `?local` parameter becomes a no-op and is marked as deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This action solely needs the cluster state, it can run on any node. Additionally, it needs to be cancellable to avoid doing unnecessary work after a client failure or timeout. The
?localparameter becomes a no-op and is marked as deprecated.Relates #101805
Relates #107984