[ML] Change the auditor to write via an alias#120064
Merged
davidkyle merged 20 commits intoelastic:mainfrom Jan 29, 2025
Merged
[ML] Change the auditor to write via an alias#120064davidkyle merged 20 commits intoelastic:mainfrom
davidkyle merged 20 commits intoelastic:mainfrom
Conversation
davidkyle
added
>upgrade
:ml
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @davidkyle, I've created a changelog YAML for you. |
davidkyle
force-pushed
the
audit-write-alias
branch
from
d6aafe4 to
53f8e44
Compare
przemekwitek
approved these changes
Jan 21, 2025
...in/core/src/main/java/org/elasticsearch/xpack/core/common/notifications/AbstractAuditor.java
Outdated
Show resolved
Hide resolved
…common/notifications/AbstractAuditor.java Co-authored-by: Przemysław Witek <przemyslaw.witek@elastic.co>
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Jan 29, 2025
Changes the ml and transform auditor classes to write through an alias. The alias is required to rollover the index which required for upgrades # Conflicts: # muted-tests.yml # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java # x-pack/qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/MlMappingsUpgradeIT.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ML and Transforms have an
Auditorthat write significant operational messages to an index. For v9 upgrades the notifications indices where the messages are stored may need upgrading, the first step of upgrade is to rollover the index which requires a alias to the index.Previously the auditor wrote to the concrete index directly, this PR switches to using an alias
MlMappingsUpgradeIT)