Skip to content

Improve how reindex data stream index action handles api blocks#120084

Merged
parkertimmins merged 2 commits intoelastic:mainfrom
parkertimmins:reindex-datastream-filter-read-only-block
Jan 14, 2025
Merged

Improve how reindex data stream index action handles api blocks#120084
parkertimmins merged 2 commits intoelastic:mainfrom
parkertimmins:reindex-datastream-filter-read-only-block

Conversation

@parkertimmins
Copy link
Contributor

  • fail quickly if index has read or metadata block
  • add write block, but also allow read-only or read-only-allow-delete
  • filter write, read-only, and read-only-allow-delete from dest index
- fail quickly if index has read or metadata block
- add write block, but also allow read-only, read-only-allow-delete
- filter write, read-only, and read-only-allow-delete from dest index
@parkertimmins parkertimmins added >enhancement :StorageEngine/Data streams Data streams and their lifecycles auto-backport Automatically create backport pull requests when merged v8.18.0 labels Jan 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @parkertimmins, I've created a changelog YAML for you.

@parkertimmins parkertimmins marked this pull request as ready for review January 14, 2025 15:00
@elasticsearchmachine elasticsearchmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Jan 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@lukewhiting lukewhiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@parkertimmins parkertimmins merged commit cd82da5 into elastic:main Jan 14, 2025
@parkertimmins parkertimmins deleted the reindex-datastream-filter-read-only-block branch January 14, 2025 16:11
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x
parkertimmins added a commit to parkertimmins/elasticsearch that referenced this pull request Jan 14, 2025
…tic#120084)

- fail quickly if index has read or metadata block
- add write block, but proceed if already has read-only or read-only-allow-delete
- filter write, read-only, and read-only-allow-delete from dest index
- results in dest index having no blocks
elasticsearchmachine pushed a commit that referenced this pull request Jan 14, 2025
) (#120132)

- fail quickly if index has read or metadata block
- add write block, but proceed if already has read-only or read-only-allow-delete
- filter write, read-only, and read-only-allow-delete from dest index
- results in dest index having no blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >enhancement :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v8.18.0 v9.0.0

3 participants