Esql - support date nanos in date format function#120143
Merged
not-napoleon merged 7 commits intoelastic:mainfrom Jan 15, 2025
Merged
Esql - support date nanos in date format function#120143not-napoleon merged 7 commits intoelastic:mainfrom
not-napoleon merged 7 commits intoelastic:mainfrom
Conversation
not-napoleon
added
>enhancement
auto-backport
Contributor
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @not-napoleon, I've created a changelog YAML for you. |
Contributor
luigidellaquila
left a comment
luigidellaquila
left a comment
There was a problem hiding this comment.
I had a quick look, it seems good.
There is only something strange in the code generation, ie. we have a /generated/generated/ folder now.
I'm pretty sure the problem is not in this PR, maybe something in your local setup?
Member
Author
|
thanks @luigidellaquila, I have no idea how those duplicate generated files happened, but I think it's fixed now. |
luigidellaquila
approved these changes
Jan 15, 2025
Contributor
luigidellaquila
left a comment
luigidellaquila
left a comment
There was a problem hiding this comment.
Thanks Mark, LGTM!
not-napoleon
added a commit
to not-napoleon/elasticsearch
that referenced
this pull request
Jan 15, 2025
This adds support for passing Date Nanos into the Date Format function. It works for both the single argument and two argument versions. Format strings are unchanged, as the same formatting logic works for both resolutions. resolves elastic#109994 --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 15, 2025
This adds support for passing Date Nanos into the Date Format function. It works for both the single argument and two argument versions. Format strings are unchanged, as the same formatting logic works for both resolutions. resolves #109994 --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for passing Date Nanos into the Date Format function. It works for both the single argument and two argument versions. Format strings are unchanged, as the same formatting logic works for both resolutions.
resolves #109994