Skip to content

ESQL: extend TranslationAware to all pushable expressions #120192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elasticsearchmachine merged 10 commits into from
Jan 17, 2025
Merged

ESQL: extend TranslationAware to all pushable expressions #120192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c48b92c
Simplify the translation hierarchy
bpintea Jan 14, 2025
fea3c22
Implement TranslationAware to translatable expressions
bpintea Jan 15, 2025
5e05041
Update docs/changelog/120192.yaml
Jan 15, 2025
85df08c
[CI] Auto commit changes from spotless
Jan 15, 2025
fa57bcf
Merge branch 'main' into enh/translation_aware
bpintea Jan 15, 2025
19d8c01
Update topN metadata attribute filtering
bpintea Jan 15, 2025
48c0d99
Add subinterface for expressions needing SV-wraapping
bpintea Jan 16, 2025
02f8d4b
Merge branch 'main' into enh/translation_aware
bpintea Jan 16, 2025
e90d987
Address review comments
bpintea Jan 17, 2025
26fea46
Merge branch 'main' into enh/translation_aware
bpintea Jan 17, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/120192.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 120192
summary: Extend `TranslationAware` to all pushable expressions
area: ES|QL
type: enhancement
issues: []
20 changes: 0 additions & 20 deletions ...sql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/TranslationAware.java
View file
Open in desktop

This file was deleted.

65 changes: 0 additions & 65 deletions ...main/java/org/elasticsearch/xpack/esql/core/expression/predicate/logical/BinaryLogic.java
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions ...ql-core/src/main/java/org/elasticsearch/xpack/esql/core/planner/ExpressionTranslator.java
View file
Open in desktop

This file was deleted.

163 changes: 0 additions & 163 deletions ...l-core/src/main/java/org/elasticsearch/xpack/esql/core/planner/ExpressionTranslators.java
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions .../esql-core/src/main/java/org/elasticsearch/xpack/esql/core/planner/TranslatorHandler.java
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions x-pack/plugin/esql-core/src/test/java/org/elasticsearch/xpack/esql/core/util/TestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,8 @@

package org.elasticsearch.xpack.esql.core.util;

import org.elasticsearch.xpack.esql.core.expression.Expression;
import org.elasticsearch.xpack.esql.core.expression.FieldAttribute;
import org.elasticsearch.xpack.esql.core.expression.Literal;
import org.elasticsearch.xpack.esql.core.expression.predicate.Range;
import org.elasticsearch.xpack.esql.core.tree.Source;
import org.elasticsearch.xpack.esql.core.type.DataType;
import org.elasticsearch.xpack.esql.core.type.EsField;
Expand All @@ -21,7 +19,6 @@
import static org.elasticsearch.test.ESTestCase.randomAlphaOfLength;
import static org.elasticsearch.test.ESTestCase.randomBoolean;
import static org.elasticsearch.test.ESTestCase.randomFrom;
import static org.elasticsearch.test.ESTestCase.randomZone;
import static org.elasticsearch.xpack.esql.core.tree.Source.EMPTY;
import static org.elasticsearch.xpack.esql.core.type.DataType.INTEGER;

Expand All @@ -44,10 +41,6 @@ public static Literal of(Source source, Object value) {
return new Literal(source, value, DataType.fromJava(value));
}

public static Range rangeOf(Expression value, Expression lower, boolean includeLower, Expression upper, boolean includeUpper) {
return new Range(EMPTY, value, lower, includeLower, upper, includeUpper, randomZone());
}

public static FieldAttribute fieldAttribute() {
return fieldAttribute(randomAlphaOfLength(10), randomFrom(DataType.types()));
}
Expand Down
2 changes: 1 addition & 1 deletion ...plugin/esql/qa/testFixtures/src/main/java/org/elasticsearch/xpack/esql/EsqlTestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
import org.elasticsearch.xpack.esql.core.expression.FoldContext;
import org.elasticsearch.xpack.esql.core.expression.Literal;
import org.elasticsearch.xpack.esql.core.expression.ReferenceAttribute;
import org.elasticsearch.xpack.esql.core.expression.predicate.Range;
import org.elasticsearch.xpack.esql.core.expression.predicate.regex.RLikePattern;
import org.elasticsearch.xpack.esql.core.expression.predicate.regex.WildcardPattern;
import org.elasticsearch.xpack.esql.core.tree.Source;
Expand All @@ -55,6 +54,7 @@
import org.elasticsearch.xpack.esql.expression.function.EsqlFunctionRegistry;
import org.elasticsearch.xpack.esql.expression.function.scalar.string.RLike;
import org.elasticsearch.xpack.esql.expression.function.scalar.string.WildcardLike;
import org.elasticsearch.xpack.esql.expression.predicate.Range;
import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.Equals;
import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.GreaterThan;
import org.elasticsearch.xpack.esql.expression.predicate.operator.comparison.GreaterThanOrEqual;
Expand Down
Loading