Add sanity check to ReindexDatastreamIndexAction#120231
Merged
parkertimmins merged 2 commits intoelastic:mainfrom Jan 16, 2025
Merged
Add sanity check to ReindexDatastreamIndexAction#120231parkertimmins merged 2 commits intoelastic:mainfrom
parkertimmins merged 2 commits intoelastic:mainfrom
Conversation
parkertimmins
added
>enhancement
:StorageEngine/Data streams
Collaborator
|
Hi @parkertimmins, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Data Management (obsolete)
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
approved these changes
Jan 16, 2025
Collaborator
💚 Backport successful
|
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Jan 16, 2025
Add an assert that checks that source and destination index have the same doc count. This requires a refresh of the dest index and a search request against both the source and dest index, so will only be run if asserts are enabled.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 16, 2025
…0295) * Add sanity check to ReindexDatastreamIndexAction (#120231) Add an assert that checks that source and destination index have the same doc count. This requires a refresh of the dest index and a search request against both the source and dest index, so will only be run if asserts are enabled. * Compilation error due to lucene totalHits change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a final sanity check after reindexing, check that the number of docs in the source index equals the number of docs in the dest index. Only run this if assertions are enabled since it requires a refresh and two search actions.