Optimize indexing points with index and doc values set to true#120271
Merged
iverase merged 7 commits intoelastic:mainfrom Jan 17, 2025
Merged
Optimize indexing points with index and doc values set to true#120271iverase merged 7 commits intoelastic:mainfrom
iverase merged 7 commits intoelastic:mainfrom
Conversation
Collaborator
|
Hi @iverase, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
craigtaverner
approved these changes
Jan 17, 2025
Contributor
craigtaverner
left a comment
There was a problem hiding this comment.
LGTM. I wonder, would these new classes ever be migrated to Lucene?
Contributor
Author
|
I tried but it developed on a discussion about the geo API which led nowhere. |
Collaborator
💚 Backport successful
|
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Jan 17, 2025
…ic#120271) Introducing at LonPoint and XYPoint that can add doc values sto improve indexing perfromance.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 17, 2025
…) (#120396) Introducing at LonPoint and XYPoint that can add doc values sto improve indexing perfromance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently using two indexing fields, one to generate the index part and another to generate the doc values .On the other hand, in many other fields we are using just one field to do this job, which has proving to improve index performance.
Therefore let's introduce here a LatLonPoint and XYPoint that can add doc values so we can get the same benefit.