[8.x] Do not serialize EsIndex in plan (#119580)#120496
Merged
idegtiarenko merged 3 commits intoelastic:8.xfrom Jan 21, 2025
Merged
[8.x] Do not serialize EsIndex in plan (#119580)#120496idegtiarenko merged 3 commits intoelastic:8.xfrom
idegtiarenko merged 3 commits intoelastic:8.xfrom
Conversation
Certain plan classes (such as EsRelation, EsSourceExec, EsQueryExec) contain and serialize the entire EsIndex instance. This instance might contain huge mapping that is never used in plan. This change replaces EsIndex usage with indexPattern and indexNameWithModes to minimize the size of the serialized plan.
alex-spies
approved these changes
Jan 21, 2025
Contributor
Author
|
The build is failing with following: Both tests have associated issues opened:
I was able to confirm they are failing without my change when running tests from 8.x I am going to mute them to unblock this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.x: