Skip to content

[8.x] Do not serialize EsIndex in plan (#119580)#120496

Merged
idegtiarenko merged 3 commits intoelastic:8.xfrom
idegtiarenko:backport/8.x/pr-119580
Jan 21, 2025
Merged

[8.x] Do not serialize EsIndex in plan (#119580)#120496
idegtiarenko merged 3 commits intoelastic:8.xfrom
idegtiarenko:backport/8.x/pr-119580

Conversation

@idegtiarenko
Copy link
Contributor

Backports the following commits to 8.x:

Certain plan classes (such as EsRelation, EsSourceExec, EsQueryExec) contain and serialize the entire EsIndex instance.
This instance might contain huge mapping that is never used in plan. This change replaces EsIndex usage with indexPattern and indexNameWithModes to minimize the size of the serialized plan.
@idegtiarenko idegtiarenko added :Analytics/ES|QL AKA ESQL >enhancement auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) test-full-bwc Trigger full BWC version matrix tests labels Jan 21, 2025
@idegtiarenko idegtiarenko removed the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 21, 2025
@idegtiarenko
Copy link
Contributor Author

The build is failing with following:

Tests with failures:
 - org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT.test {date.IN operator with null in list, doesn't find match}
 - org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT.test {date.IN operator with null in list, doesn't find match, EVAL to check value}

Both tests have associated issues opened:

I was able to confirm they are failing without my change when running tests from 8.x

I am going to mute them to unblock this PR.

@idegtiarenko idegtiarenko removed the test-full-bwc Trigger full BWC version matrix tests label Jan 21, 2025
@idegtiarenko idegtiarenko merged commit 7284a69 into elastic:8.x Jan 21, 2025
15 checks passed
@idegtiarenko idegtiarenko deleted the backport/8.x/pr-119580 branch January 21, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL backport >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0

3 participants