Revert unwanted ES|QL lexer changes from PR #120354#120538
Merged
tteofili merged 2 commits intoelastic:mainfrom Jan 21, 2025
Merged
Revert unwanted ES|QL lexer changes from PR #120354#120538tteofili merged 2 commits intoelastic:mainfrom
tteofili merged 2 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @tteofili, I've created a changelog YAML for you. |
carlosdelest
approved these changes
Jan 21, 2025
Member
carlosdelest
left a comment
carlosdelest
left a comment
There was a problem hiding this comment.
LGTM.
I'd say this is not a bug yet as it was not experienced by customers - I'd remove the >bug and the changelog.yml, and set this as a >non-issue.
tteofili
added a commit
to tteofili/elasticsearch
that referenced
this pull request
Jan 27, 2025
…20538) * Revert unwanted ES|QL lexer changes from PR elastic#120354 * Update docs/changelog/120538.yaml (cherry picked from commit 04b5b7a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, PR #120354 made some unwanted changes to the ES|QL lexer file, reverting them.