Report Deprecated Indices That Are Flagged To Ignore Migration Reindex As A Warning#120629
Conversation
lukewhiting
added
:StorageEngine/Data streams
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management (obsolete)
|
Pinging @henningandersen as he originally proposed this functionality |
|
Hi @lukewhiting, I've created a changelog YAML for you. |
...in/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecks.java
Outdated
Show resolved
Hide resolved
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
LGTM
left a few comments. Did not review tests, assuming others do.
...precation/src/main/java/org/elasticsearch/xpack/deprecation/DataStreamDeprecationChecks.java
Outdated
Show resolved
Hide resolved
| "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html", | ||
| "This index has version: " | ||
| + currentCompatibilityVersion.toReleaseVersion() | ||
| + " and has been marked as OK to become read-only after upgrade", |
There was a problem hiding this comment.
It is already read-only, can we reflect that in the message?
There was a problem hiding this comment.
Have changed "become" to "remain". Still not 100% sure it's right... I want to try and capture these facts:
- The index isn't writable after upgrade
- It's currently read only
- The user had taken affirmative action to say this scenario is OK
There was a problem hiding this comment.
I'd probably prefer to avoid the last bit. Perhaps just say it is read-only and will be supported as read-only in 9?
There was a problem hiding this comment.
Something like:
This read only index has version: 7.0 and will be supported only as read only in 9.0?
There was a problem hiding this comment.
Looks good to me, thanks.
💔 Backport failed
You can use sqren/backport to manually backport by running |
…Reinde… (#120709) * Report Deprecated Indices That Are Flagged To Ignore Migration Reindex As A Warning (#120629) * Add block state matching option to deprecation check predicate * Add new deprecation checks to warn on old indices with ignore reindex flag * Test for new deprecation checks * Update docs/changelog/120629.yaml * PR Changes - Remove leftover comment that's no longer true (cherry picked from commit 45ae071) * Update notice wording for 8.x
4 participants
Adds a new deprecation at WARNING vs CRITICAL level when a user has an index which will become unwritable in the next version and they have marked that index as OK to be ignored for reindexing and become read only after upgrade.
This allows users to keep track of which indices they have marked to be ignored in the Kibana migration assistant.
Fixes ES-10578