Remove duplicate code in ESIntegTestCase#120799
Merged
drempapis merged 37 commits intoelastic:mainfrom Jan 27, 2025
Merged
Conversation
elasticsearchmachine
added
v9.0.0
needs:triage
drempapis
commented
Jan 24, 2025
| ); | ||
|
|
||
| // Compare the stateMaps for equality. | ||
| assertNull(XContentTestUtils.differenceBetweenMapsIgnoringArrayOrder(masterStateMap, localStateMap)); |
Contributor
Author
drempapis
added
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
removed
the
needs:triage
drempapis
added
>bug
needs:triage
Collaborator
|
Hi @drempapis, I've created a changelog YAML for you. |
thecoop
approved these changes
Jan 24, 2025
Member
thecoop
left a comment
thecoop
left a comment
There was a problem hiding this comment.
Oh yes - this is more a refactor though, not a bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of this #120392 pr; removing duplicate code previously introduced