[ML] Remove Elastic Inference Service feature flag and deprecated setting#120842
Merged
demjened merged 6 commits intoelastic:mainfrom Jan 28, 2025
Merged
[ML] Remove Elastic Inference Service feature flag and deprecated setting#120842demjened merged 6 commits intoelastic:mainfrom
demjened merged 6 commits intoelastic:mainfrom
Conversation
demjened
added
auto-backport
demjened
force-pushed
the
demjened/remove-eis-feature-flag
branch
from
4775476 to
b7b2a1f
Compare
demjened
changed the title
elasticsearchmachine
added
Team:SearchOrg
Collaborator
|
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Collaborator
|
Pinging @elastic/search-eng (Team:SearchOrg) |
demjened
changed the title
Contributor
|
/cc @vidok We don't need to set the feature flag for ECH. |
demjened
force-pushed
the
demjened/remove-eis-feature-flag
branch
from
09cde0b to
fa37a35
Compare
demjened
force-pushed
the
demjened/remove-eis-feature-flag
branch
from
c3b6f91 to
289277f
Compare
Collaborator
|
Hi @demjened, I've created a changelog YAML for you. |
demjened
changed the title
maxjakob
reviewed
Jan 28, 2025
Contributor
maxjakob
left a comment
maxjakob
left a comment
There was a problem hiding this comment.
LGTM, but there are still merge conflicts
maxjakob
reviewed
Jan 28, 2025
...ce-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceGetServicesIT.java
Show resolved
Hide resolved
Contributor
We don't set them for hosted. All FFs are enabled for snapshots and always disabled for normal builds. So no actions are required from our side. |
maxjakob
approved these changes
Jan 28, 2025
vidok
approved these changes
Jan 28, 2025
brendan-jugan-elastic
approved these changes
Jan 28, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing Elastic Inference Service (EIS) feature flag and deprecated URL setting in favor of an access control method inside EIS.