Fix privileges for system index migration WRITE block #121327
Merged
JVerwolf merged 15 commits intoelastic:mainfrom Feb 10, 2025
Merged
Fix privileges for system index migration WRITE block #121327JVerwolf merged 15 commits intoelastic:mainfrom
JVerwolf merged 15 commits intoelastic:mainfrom
Conversation
…ix-priveledges-in-system-migration-block-main
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @JVerwolf, I've created a changelog YAML for you. |
…ix-priveledges-in-system-migration-block-main
…of github.com:JVerwolf/elasticsearch into bugfix/fix-priveledges-in-system-migration-block-main
…ix-priveledges-in-system-migration-block-main
…ix-priveledges-in-system-migration-block-main
Contributor
|
Do we need two changelog files? |
alexey-ivanov-es
approved these changes
Feb 3, 2025
jakelandis
reviewed
Feb 5, 2025
| "indices:data/read/*", // needed for SystemIndexMigrator | ||
| "indices:admin/refresh", // needed for SystemIndexMigrator | ||
| "indices:admin/aliases", // needed for SystemIndexMigrator | ||
| TransportAddIndexBlockAction.TYPE.name() + "*", // needed for SystemIndexMigrator |
Contributor
There was a problem hiding this comment.
this change w.r.t. security LGTM ( I have not reviewed the rest of the code)
Contributor
Author
|
@elasticmachine update branch |
JVerwolf
added
the
auto-backport
Contributor
Author
|
@elasticmachine update branch |
…ix-priveledges-in-system-migration-block-main
…of github.com:JVerwolf/elasticsearch into bugfix/fix-priveledges-in-system-migration-block-main
JVerwolf
added a commit
to JVerwolf/elasticsearch
that referenced
this pull request
Feb 10, 2025
This PR removes a potential cause of data loss when migrating system indices. It does this by changing the way we set a "write-block" on the system index to migrate - now using a dedicated transport request rather than a settings update. Furthermore, we no longer delete the write-block prior to deleting the index, as this was another source of potential data loss. Additionally, we now remove the block if the migration fails.
This was referenced Feb 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 10, 2025
* Fix privileges for system index migration WRITE block (#121327) This PR removes a potential cause of data loss when migrating system indices. It does this by changing the way we set a "write-block" on the system index to migrate - now using a dedicated transport request rather than a settings update. Furthermore, we no longer delete the write-block prior to deleting the index, as this was another source of potential data loss. Additionally, we now remove the block if the migration fails. * Update release notes * Delete docs/changelog/122214.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #121119 with a fix for #120168, which was causing the system index migration service to fail when security was enabled.
The fix is to add the priviledge:
to the
_systemuser. This allows the system user to access the "blocks" API.This PR removes a potential cause of data loss when migrating system indices. It does this by changing the way we set a "write-block" on the system index to migrate - now using a dedicated transport request rather than a settings update. Furthermore, we no longer delete the write-block prior to deleting the index, as this was another source of potential data loss. Additionally, we now remove the block if the migration fails.
8.x Branch PR: #121329