Updates to allow using Cohere binary embedding response in semantic search queries.#121827
Merged
ymao1 merged 18 commits intoelastic:mainfrom Feb 25, 2025
Merged
Updates to allow using Cohere binary embedding response in semantic search queries.#121827ymao1 merged 18 commits intoelastic:mainfrom
ymao1 merged 18 commits intoelastic:mainfrom
Conversation
…o more-cohere-bits
Collaborator
|
Hi @ymao1, I've created a changelog YAML for you. |
Contributor
Author
|
Waiting for @davidkyle to give a 👍 after running some validation tests. |
Mikep86
reviewed
Feb 21, 2025
| : inference.length; | ||
| if (inferenceLength != modelSettings.dimensions()) { | ||
| throw new IllegalArgumentException( | ||
| generateDimensionCountMismatchMessage(inference.length, modelSettings.dimensions()) |
Contributor
There was a problem hiding this comment.
Let's make sure to update this error message with the correct dimension count as well
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Mikep86
approved these changes
Feb 24, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
ymao1
added a commit
to ymao1/elasticsearch
that referenced
this pull request
Feb 25, 2025
…earch queries. (elastic#121827) * wip * wip * [CI] Auto commit changes from spotless * updating tests * [CI] Auto commit changes from spotless * Update docs/changelog/121827.yaml * Updates after the refactor * [CI] Auto commit changes from spotless * Updating error message --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit e843849) # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/InferenceTextEmbeddingBitResults.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/chunking/EmbeddingRequestChunkerTests.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
ymao1
added a commit
to ymao1/elasticsearch
that referenced
this pull request
Feb 27, 2025
…earch queries. (elastic#121827) * wip * wip * [CI] Auto commit changes from spotless * updating tests * [CI] Auto commit changes from spotless * Update docs/changelog/121827.yaml * Updates after the refactor * [CI] Auto commit changes from spotless * Updating error message --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit e843849) # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/TextEmbeddingBitResults.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 27, 2025
…ntic search queries. (#121827) (#123625) * Updates to allow using Cohere binary embedding response in semantic search queries. (#121827) * wip * wip * [CI] Auto commit changes from spotless * updating tests * [CI] Auto commit changes from spotless * Update docs/changelog/121827.yaml * Updates after the refactor * [CI] Auto commit changes from spotless * Updating error message --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit e843849) # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/TextEmbeddingBitResults.java * Fixing compile error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates to get semantic search working with bit embeddings.
Verify
Following the instructions in this tutorial:
This will verify that the process of using a inference endpoint with binary embedding works with semantic text queries.
Load data as directed by the the tutorial
Reindex the data