Fix handling of auto expand replicas for stateless indices#122365
Merged
javanna merged 4 commits intoelastic:mainfrom Feb 12, 2025
Merged
Fix handling of auto expand replicas for stateless indices#122365javanna merged 4 commits intoelastic:mainfrom
javanna merged 4 commits intoelastic:mainfrom
Conversation
Auto expand replicas is meant to be entirely disabled for stateless indices. The only scenario where a change needs to be applied is when the number of replicas is initialized to 0, in which case 0 needs to be turned into 1. Otherwise, no changes should be applied in stateless indices despite auto expand replicas is used. The current handling for this was missing an early exit of the indices loop in the case where 0 shoudl be turned into 1, that leads to a potentially higher number of copies being allocated (effectively auto-expand gets applied by mistake).
javanna
added
>bug
:Distributed/Distributed
elasticsearchmachine
added
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Collaborator
|
Hi @javanna, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
javanna
removed
the
:Distributed/Distributed
elasticsearchmachine
removed
the
Team:Distributed Indexing (obsolete)
piergm
approved these changes
Feb 12, 2025
Member
piergm
left a comment
piergm
left a comment
There was a problem hiding this comment.
LGTM! Thanks for working on this Luca! 👍
javanna
added
the
:Distributed/Distributed
elasticsearchmachine
added
the
Team:Distributed Indexing (obsolete)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto expand replicas is meant to be entirely disabled for stateless indices. The only scenario where a change needs to be applied is when the number of replicas is initialized to 0, in which case 0 needs to be turned into 1. Otherwise, no changes should be applied in stateless indices despite auto expand replicas is used.
The current handling for this was missing an early exit of the indices loop in the case where 0 shoudl be turned into 1, that leads to a potentially higher number of copies being allocated (effectively auto-expand gets applied by mistake).